Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Fix iOS widget has a white border #4011

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

ArtCC
Copy link
Contributor

@ArtCC ArtCC commented Jan 25, 2024

Fixed bug showing white background in widget due to a change in iOS 17.

#4005

@ArtCC ArtCC requested a review from a team as a code owner January 25, 2024 16:44
@ArtCC ArtCC changed the title Fix iOS widget has a white border #4005 Fix iOS widget has a white border Jan 25, 2024
@ArtCC
Copy link
Contributor Author

ArtCC commented Jan 29, 2024

What do I have to do to have this pull request and the conflict reviewed? Thank you!

@isabelrios
Copy link
Collaborator

@razvanlitianu @PARAIPAN9 Could you please take a look at this PR?

Copy link
Contributor

@razvanlitianu razvanlitianu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested your solution for the PR - it's spot on!

@ArtCC
Copy link
Contributor Author

ArtCC commented Jan 29, 2024

Just tested your solution for the PR - it's spot on!

Great, what does 'needs landing (Squash)' mean?

Thank you!

@mergify mergify bot merged commit c1614e8 into mozilla-mobile:main Jan 29, 2024
7 checks passed
@ArtCC ArtCC deleted the fix/widgetHasWhiteBorder#4005 branch January 29, 2024 13:57
@razvanlitianu
Copy link
Contributor

Just tested your solution for the PR - it's spot on!

Great, what does 'needs landing (Squash)' mean?

Thank you!

It's a trigger for Mergify to safely merge PRs.

@ArtCC
Copy link
Contributor Author

ArtCC commented Jan 29, 2024

It's a trigger for Mergify to safely merge PRs.

I imagined it when I saw the Bitrise workflow start.

Thank you so much!

isabelrios pushed a commit to isabelrios/firefox-ios that referenced this pull request Feb 14, 2024
* Fix iOS widget has a white border mozilla-mobile/focus-ios#4005

* Fix padding.

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this pull request Feb 20, 2024
…os#4011)

* Fix iOS widget has a white border mozilla-mobile/focus-ios#4005

* Fix padding.

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants