Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Commit

Permalink
Fix invisible Find Previous & Find Next buttons
Browse files Browse the repository at this point in the history
Move the corresponding icon assets to the DesginSystem module so that
they can be found at runtime.

Fixes #3699
  • Loading branch information
sryze committed Feb 9, 2024
1 parent 09cc54c commit ec5f63a
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions focus-ios/Blockzilla/Utilities/FindInPageBar.swift
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ class FindInPageBar: UIView {
matchCountView.accessibilityIdentifier = "FindInPage.matchCount"
addSubview(matchCountView)

previousButton.setImage(UIImage(named: "find_previous"), for: [])
previousButton.setImage(.findPrevious, for: [])
previousButton.setTitleColor(.white, for: [])
previousButton.accessibilityLabel = UIConstants.strings.findInPagePreviousLabel
previousButton.addTarget(self, action: #selector(didFindPrevious), for: .touchUpInside)
previousButton.accessibilityIdentifier = "FindInPage.find_previous"
addSubview(previousButton)

nextButton.setImage(UIImage(named: "find_next"), for: [])
nextButton.setImage(.findNext, for: [])
nextButton.setTitleColor(.white, for: [])
nextButton.accessibilityLabel = UIConstants.strings.findInPageNextLabel
nextButton.addTarget(self, action: #selector(didFindNext), for: .touchUpInside)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,8 @@ public extension UIImage {
static let delete = UIImage(named: "icon_delete")!
static let hamburgerMenu = UIImage(named: "icon_hamburger_menu")!
static let stopMenu = UIImage(named: "icon_stop_menu")!

// MARK: Find In Page
static let findPrevious = UIImage(named: "find_previous")!
static let findNext = UIImage(named: "find_next")!
}

0 comments on commit ec5f63a

Please sign in to comment.