Bugfix MTE-4206 macos-15 Github Actions runner and Xcode 16.2 #23904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 0d43594 |
dragosb01
approved these changes
Dec 20, 2024
|
@Mergifyio backport release/v134 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Try bumping xcpretty * Bumping xcode versions * Use arm64 runners? * Looks like we cannot use arm64 runners :( * Don't use arm64 flag * Install erb package (used by xcpretty) manually * Don't tee the log to see what happens * Forgot about xcpretty for now * Just run smoke test * Pipe everything to tee * uninstall xcpretty before downgrade * Uninstall specific version * Let's uninstall again * Force 0.3.0 of xcpretty * Put back some reporting? * Let's confirm if old xcpretty is the fix! * Fix identation * Pin xcpretty version for previous iOS tests * No need to install ruby and python packages for compilation * Put back ARCH arguments * Let's use the same arguments on previous-os.yml * Try iOS 17.4 instead of 17.5 * Fix result directories * Query existing runtimes * Use iOS 17.5 instead * Improve message for not installing runtime * We confirmed the xcpretty version :) * Print mesg if old runtime is needed * Let's try for iOS 16 and 15 * What is output? * Use -z? * Why grep failed? * Do you like these quotes? * Can we grep? * Prevent non-match to exit the workflow * Put iOS 17.5 back (cherry picked from commit 622b94a)
6 tasks
clarmso
added a commit
that referenced
this pull request
Jan 8, 2025
#23904) (#23917) Bugfix MTE-4206 macos-15 Github Actions runner and Xcode 16.2 (#23904) * Try bumping xcpretty * Bumping xcode versions * Use arm64 runners? * Looks like we cannot use arm64 runners :( * Don't use arm64 flag * Install erb package (used by xcpretty) manually * Don't tee the log to see what happens * Forgot about xcpretty for now * Just run smoke test * Pipe everything to tee * uninstall xcpretty before downgrade * Uninstall specific version * Let's uninstall again * Force 0.3.0 of xcpretty * Put back some reporting? * Let's confirm if old xcpretty is the fix! * Fix identation * Pin xcpretty version for previous iOS tests * No need to install ruby and python packages for compilation * Put back ARCH arguments * Let's use the same arguments on previous-os.yml * Try iOS 17.4 instead of 17.5 * Fix result directories * Query existing runtimes * Use iOS 17.5 instead * Improve message for not installing runtime * We confirmed the xcpretty version :) * Print mesg if old runtime is needed * Let's try for iOS 16 and 15 * What is output? * Use -z? * Why grep failed? * Do you like these quotes? * Can we grep? * Prevent non-match to exit the workflow * Put iOS 17.5 back (cherry picked from commit 622b94a) Co-authored-by: Clare So <[email protected]>
mdotb-moz
pushed a commit
that referenced
this pull request
Jan 14, 2025
#23904) (#23917) Bugfix MTE-4206 macos-15 Github Actions runner and Xcode 16.2 (#23904) * Try bumping xcpretty * Bumping xcode versions * Use arm64 runners? * Looks like we cannot use arm64 runners :( * Don't use arm64 flag * Install erb package (used by xcpretty) manually * Don't tee the log to see what happens * Forgot about xcpretty for now * Just run smoke test * Pipe everything to tee * uninstall xcpretty before downgrade * Uninstall specific version * Let's uninstall again * Force 0.3.0 of xcpretty * Put back some reporting? * Let's confirm if old xcpretty is the fix! * Fix identation * Pin xcpretty version for previous iOS tests * No need to install ruby and python packages for compilation * Put back ARCH arguments * Let's use the same arguments on previous-os.yml * Try iOS 17.4 instead of 17.5 * Fix result directories * Query existing runtimes * Use iOS 17.5 instead * Improve message for not installing runtime * We confirmed the xcpretty version :) * Print mesg if old runtime is needed * Let's try for iOS 16 and 15 * What is output? * Use -z? * Why grep failed? * Do you like these quotes? * Can we grep? * Prevent non-match to exit the workflow * Put iOS 17.5 back (cherry picked from commit 622b94a) Co-authored-by: Clare So <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
This PR address the following caused by the Xcode 16 and the Github Actions runner upgrade:
xcprettydoes not work if a test fails, even intermittently. We pin the version ofxcprettyto 0.3.0 instead of using 0.4.0 from the Github Actionsmacos-15runner. (We have installed v0.3.0 previously, but we did not pin the version.)Focus for iOS 15, 16 and 17: https://github.com/mozilla-mobile/firefox-ios/actions/runs/12422652690
Focus UI Tests: https://github.com/mozilla-mobile/firefox-ios/actions/runs/12422654698
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)