Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - auto update credential provider script #23304

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 22, 2024

Messages
📖 Edited 5 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 72c1bab

Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The breaking code was caused by adding a telemetry ping on Desktop that wasn't added to Helpers.ios.mjs. I manually pulled the fix. Will merge once BR is green.

@issammani
Copy link
Collaborator

Merging since general BR is green and only testAddNewAddressAllFieldsFilled is failing which is also failing on main.

@issammani issammani merged commit 4f73569 into main Nov 22, 2024
10 of 11 checks passed
@issammani issammani deleted the update-cred-provider-script branch November 22, 2024 13:44
clarmso pushed a commit that referenced this pull request Nov 25, 2024
* Refactor - auto update credential provider script

* fix: pull fix from central

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Issam Mani <[email protected]>
isabelrios pushed a commit that referenced this pull request Dec 3, 2024
* Refactor - auto update credential provider script

* fix: pull fix from central

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Issam Mani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants