Bugfix MTE-3781 Use of https in history and bookmarks #22889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against fb4cf15 |
clarmso
commented
Nov 5, 2024
| private let loginEntry = "https://accounts.google.com" | ||
| private let tabOpenInDesktop = "http://example.com/" | ||
| private let tabOpenInDesktop = "https://example.com/" |
There was a problem hiding this comment.
On desktop, the URL is redirected to https.
isabelrios
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
test_integration.py::test_sync_tabs_from_desktopfails because an http URL opened on desktop may be redirected to https. The tabs state in the js file specifies the URL in http.Let me use https URL throughout the sync integration tests so that we don't need to take care of the http to https redirection.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)