Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10418 [Menu] [Accessibility] Update accessibility strings for tools #22886

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Bugfix FXIOS-10418 [Menu] [Accessibility] Update accessibility strings for tools #22886

merged 1 commit into from
Nov 4, 2024

Conversation

adudenamedruby
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Update string to have submenu for the a11y string

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@adudenamedruby adudenamedruby requested a review from a team as a code owner November 4, 2024 19:29
@adudenamedruby adudenamedruby requested review from PARAIPAN9 and cyndichin and removed request for PARAIPAN9 November 4, 2024 19:29
@adudenamedruby
Copy link
Contributor Author

@mergify backport release/v133

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024 •
edited
Loading

backport release/v133

✅ Backports have been created

@mobiletest-ci-bot
Copy link

Messages
📖 Edited 1 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 2bb5b24

@adudenamedruby adudenamedruby merged commit 1b62cd7 into main Nov 4, 2024
9 of 10 checks passed
@adudenamedruby adudenamedruby deleted the rgb/accessibilityStringMenuFix branch November 4, 2024 19:53
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@adudenamedruby @mergify
Bugfix FXIOS-10418 [Menu] [Accessibility] Update accessibility string…
9fc80d1 
…s for tools (#22886)

Update accessibility strings for tools

(cherry picked from commit 1b62cd7)
@mergify mergify bot mentioned this pull request Nov 4, 2024
Merged
6 tasks
adudenamedruby added a commit that referenced this pull request Nov 4, 2024
@mergify @adudenamedruby
Bugfix FXIOS-10418 [Menu] [Accessibility] Update accessibility string…
8430923 
…s for tools (backport #22886) (#22887)

Bugfix FXIOS-10418 [Menu] [Accessibility] Update accessibility strings for tools (#22886)

Update accessibility strings for tools

(cherry picked from commit 1b62cd7)

Co-authored-by: roux g. buciu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyndichin cyndichin cyndichin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adudenamedruby @mobiletest-ci-bot @cyndichin