Bugfix FXIOS-9859 Don’t call apply theme for every tab #22746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 30.51
Generated by 🚫 Danger Swift against ac92395 |
nbhasin2
approved these changes
Oct 24, 2024
adudenamedruby
approved these changes
Oct 24, 2024
|
@Mergifyio backport release/v132 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
Don’t call apply theme for every tab (cherry picked from commit 1193861)
6 tasks
rvandermeulen
pushed a commit
that referenced
this pull request
Nov 4, 2024
…) (#22750) Bugfix FXIOS-9859 Don’t call apply theme for every tab (#22746) Don’t call apply theme for every tab (cherry picked from commit 1193861) Co-authored-by: OrlaM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
There was an increase in hang rate some time around release v129. Since the problem area in calling apply theme my top suspect is this PR #20667.
The hang rate report from apple pre-dates 129 but it gets much worse in 129. Many of the logs accompanying the metric kit event for our beta builds in Sentry indicate the users experiencing this issue have a large number of tabs (> 100).
I think it's likely something in the refactor above is causing the apply theme to fire more often and since apply theme is triggered on every tab this has the potential to bog things down.
This PR triggers apply theme on just the selected PR as that is the only place it's really needed. The background of blank tabs get updated when they are selected.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)