Add FXIOS-9964 - Integrate password generator inside password manager script #22150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issammani
commented
Sep 23, 2024
| @@ -42,20 +42,23 @@ | |||
| "toolkit/modules/third_party/fathom/fathom.mjs", | |||
| "toolkit/components/passwordmgr/shared/LoginFormFactory.sys.mjs", | |||
| "toolkit/components/passwordmgr/shared/NewPasswordModel.sys.mjs", | |||
| "toolkit/components/passwordmgr/shared/PasswordGenerator.sys.mjs ", | |||
| "toolkit/components/passwordmgr/shared/PasswordGenerator.sys.mjs", | |||
There was a problem hiding this comment.
Space typo caused this file not be pulled 😅
nbhasin2
reviewed
Sep 23, 2024
nbhasin2
reviewed
Sep 23, 2024
firefox-ios/Client/Frontend/UserContent/UserScripts/AllFrames/AtDocumentStart/LoginsHelper.js
Outdated
Show resolved
Hide resolved
nbhasin2
reviewed
Sep 23, 2024
firefox-ios/Client/Frontend/UserContent/UserScripts/AllFrames/AtDocumentStart/LoginsHelper.js
Show resolved
Hide resolved
nbhasin2
approved these changes
Sep 23, 2024
issammani
force-pushed
the
feat/integrate-password-generator-with-logins-helper
branch
from
f96d3bd to
6ce59ca
Compare
Generated by 🚫 Danger Swift against 6ce59ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This PR:
CC_Python_Update.pygeneratePasswordwill be called by swift to get a password for the current domain.fillGeneratedPasswordwill be called by swift to fill a password and confirmation field if it exists.postMessage({ type: "generatePassword"})will be sent by JS to swift when anew-passwordfield is detected.📝 Checklist
You have to check all boxes before merging
Wrote unit tests and/or ensured the tests suite is passingWhen working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)If needed, I updated documentation / comments for complex code and public methodsIf needed, added a backport comment (example@Mergifyio backport release/v120)