-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix FXIOS-9407: Open deeplinks in correct browsing mode #20927
Closed
MattLichtenstein
wants to merge
9
commits into
main
from
FXIOS-9407_Open-Deeplinks-In-Correct-Browsing-Mode
Closed
Bugfix FXIOS-9407: Open deeplinks in correct browsing mode #20927
MattLichtenstein
wants to merge
9
commits into
main
from
FXIOS-9407_Open-Deeplinks-In-Correct-Browsing-Mode
+117
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has conflicts when rebasing. Could you fix it @MattLichtenstein? 🙏 |
MattLichtenstein
force-pushed
the
FXIOS-9407_Open-Deeplinks-In-Correct-Browsing-Mode
branch
from
July 11, 2024 19:41
1863eba
to
038bbea
Compare
This pull request has conflicts when rebasing. Could you fix it @MattLichtenstein? 🙏 |
MattLichtenstein
force-pushed
the
FXIOS-9407_Open-Deeplinks-In-Correct-Browsing-Mode
branch
from
July 17, 2024 22:04
b71eb23
to
7f47ae8
Compare
Client.app: Coverage: 30.51
Generated by 🚫 Danger Swift against e38302f |
This pull request has conflicts when rebasing. Could you fix it @MattLichtenstein? 🙏 |
adudenamedruby
requested review from
adudenamedruby
and removed request for
razvanlitianu
July 23, 2024 17:10
adudenamedruby
added
the
Do Not Merge ⛔️
This issue is a work in progress and is not ready to land
label
Jul 30, 2024
rvandermeulen
deleted the
FXIOS-9407_Open-Deeplinks-In-Correct-Browsing-Mode
branch
August 16, 2024 10:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This bug essentially states that all links opened from outside the apps main target will open in regular browsing mode. Although all private browsing data is cleared when the app is killed, these paths may not always be initiated while the app is not in memory, and therefore, could happen while the app is currently in private browsing (via a private
selectedTab
). To prevent the user from accidentally switching browsing modes, the following changes were made:Also fixed was a bug where search queries (saved in the pasteboard as strings instead or URL's, even if they are well-formed URL's) opened via “Go to copied link” widget would navigate to the respective web page before the newly created tab was selected, causing the app to display a blank/homescreen tab to the user, while the navigation intended to take place on the new tab, happened in the previously open tab
Notes:
Testing:
To test these changes, ensure all links opened in Firefox from outside the app open in Firefoxes current browsing mode (regular or private). This includes:
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)