Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-9118 - Add long press action to tabs button #20586

Merged

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Jun 7, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

PARAIPAN9 and others added 22 commits May 27, 2024 23:37
…ard-buttons' into sparaipan/fxios-9118-Add-long-press-action-to-tabs-button
@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner June 7, 2024 11:25
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.11%
📖 Edited 6 files
📖 Created 0 files

Client.app: Coverage: 30.72

File Coverage
BrowserViewController+TabToolbarDelegate.swift 12.22% ⚠️
GeneralBrowserAction.swift 0.0% ⚠️
BrowserViewController.swift 4.16% ⚠️
BrowserViewControllerState.swift 0.0% ⚠️
ToolbarState.swift 5.13% ⚠️
ToolbarMiddleware.swift 7.14% ⚠️

Generated by 🚫 Danger Swift against 2880265

@PARAIPAN9 PARAIPAN9 merged commit b41ea57 into main Jun 7, 2024
9 of 11 checks passed
@PARAIPAN9 PARAIPAN9 deleted the sparaipan/fxios-9118-Add-long-press-action-to-tabs-button branch June 7, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants