Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-9067 - Add addressFormLayout.js file to be pulled from mozilla-centra #20081

Merged
merged 3 commits into from
May 2, 2024
Merged

Add FXIOS-9067 - Add addressFormLayout.js file to be pulled from mozilla-centra #20081

merged 3 commits into from
May 2, 2024

Conversation

issammani
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR:

  • Adds addressFormLayout.js to list of pulled scripts from mozilla-central.

NOTE: This is the file responsible for the layout of each country's address format.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@issammani issammani requested a review from nbhasin2 as a code owner April 30, 2024 13:51
@issammani issammani force-pushed the chore/add-address-ui-js-file branch from 9124e6a to 6e06ce1 Compare April 30, 2024 13:53
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Apr 30, 2024 •
edited
Loading

Messages
📖 Edited 1 files
📖 Created 0 files

Generated by 🚫 Danger Swift against b688632

@nbhasin2 nbhasin2 added the Needs Landing (Squash) Label used by mergify to land PR with several commits label May 1, 2024
@nbhasin2 nbhasin2 closed this May 1, 2024
@nbhasin2 nbhasin2 reopened this May 1, 2024
@nbhasin2
Copy link
Contributor

nbhasin2 commented May 1, 2024

BR is not showing up: https://app.bitrise.io/app/6c06d3a40422d10f/pipelines/28ef239d-ca89-4fc7-8c04-9e35b5a98a01

@nbhasin2 nbhasin2 closed this May 2, 2024
@nbhasin2 nbhasin2 reopened this May 2, 2024
@nbhasin2
Copy link
Contributor

nbhasin2 commented May 2, 2024

BR is acting up @issammani and this file is for Python script so should not be related to our changes

@nbhasin2 nbhasin2 changed the title Add FXIOS-9067 - Add addressFormLayout.js to pulled files from mozilla-central Add FXIOS-9067 - Add addressFormLayout.js files to be pulled from mozilla-centra May 2, 2024
@nbhasin2 nbhasin2 changed the title Add FXIOS-9067 - Add addressFormLayout.js files to be pulled from mozilla-centra Add FXIOS-9067 - Add addressFormLayout.js file to be pulled from mozilla-centra May 2, 2024
@nbhasin2 nbhasin2 merged commit 47c8178 into mozilla-mobile:main May 2, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbhasin2 nbhasin2 nbhasin2 approved these changes

Assignees
No one assigned
Labels
Needs Landing (Squash) Label used by mergify to land PR with several commits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@issammani @mobiletest-ci-bot @nbhasin2