Add FXIOS-10717 [sponsored tiles] Add feature flag for unified ads API (

#23441) * Add feature flag for unified ads * Forgot to add debugKey
mozilla-mobile · Nov 28, 2024 · eb615fa · eb615fa
1 parent 57009ea
commit eb615fa
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 0 deletions.
diff --git a/firefox-ios/Client/FeatureFlags/NimbusFlaggableFeature.swift b/firefox-ios/Client/FeatureFlags/NimbusFlaggableFeature.swift
@@ -42,6 +42,7 @@ enum NimbusFeatureFlagID: String, CaseIterable {
     case searchHighlights
     case sentFromFirefox
     case splashScreen
+    case unifiedAds
     case unifiedSearch
     case toolbarRefactor
     case toolbarOneTapNewTab
@@ -64,6 +65,7 @@ enum NimbusFeatureFlagID: String, CaseIterable {
                 .toolbarRefactor,
                 .trackingProtectionRefactor,
                 .passwordGenerator,
+                .unifiedAds,
                 .unifiedSearch:
             return rawValue + PrefsKeys.FeatureFlags.DebugSuffixKey
         default:
@@ -127,6 +129,7 @@ struct NimbusFlaggableFeature: HasNimbusSearchBar {
                 .feltPrivacyFeltDeletion,
                 .searchHighlights,
                 .splashScreen,
+                .unifiedAds,
                 .unifiedSearch,
                 .toolbarRefactor,
                 .toolbarOneTapNewTab,

diff --git a/...os/Client/Frontend/Settings/Main/Debug/FeatureFlags/FeatureFlagsDebugViewController.swift b/...os/Client/Frontend/Settings/Main/Debug/FeatureFlags/FeatureFlagsDebugViewController.swift
@@ -88,6 +88,13 @@ final class FeatureFlagsDebugViewController: SettingsTableViewController, Featur
                 ) { [weak self] _ in
                     self?.reloadView()
                 },
+                FeatureFlagsBoolSetting(
+                    with: .unifiedAds,
+                    titleText: format(string: "Enable Unified Ads"),
+                    statusText: format(string: "Toggle to use unified ads API")
+                ) { [weak self] _ in
+                    self?.reloadView()
+                },
                 FeatureFlagsBoolSetting(
                     with: .unifiedSearch,
                     titleText: format(string: "Enable Unified Search"),

diff --git a/firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift b/firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift
@@ -103,6 +103,9 @@ final class NimbusFeatureFlagLayer {
         case .toolbarRefactor:
             return checkToolbarRefactorFeature(from: nimbus)
 
+        case .unifiedAds:
+            return checkUnifiedAdsFeature(from: nimbus)
+
         case .unifiedSearch:
             return checkUnifiedSearchFeature(from: nimbus)
 
@@ -204,6 +207,11 @@ final class NimbusFeatureFlagLayer {
         return config.enabled
     }
 
+    private func checkUnifiedAdsFeature(from nimbus: FxNimbus) -> Bool {
+        let config = nimbus.features.unifiedAds.value()
+        return config.enabled
+    }
+
     private func checkUnifiedSearchFeature(from nimbus: FxNimbus) -> Bool {
         let config = nimbus.features.toolbarRefactorFeature.value()
         return config.unifiedSearch

diff --git a/firefox-ios/nimbus-features/unifiedAds.yaml b/firefox-ios/nimbus-features/unifiedAds.yaml
@@ -0,0 +1,18 @@
+# The configuration for the unifiedAds feature
+features:
+  unified-ads:
+    description: >
+      This property is for managing the roll out of the unified ads API
+    variables:
+      enabled:
+        description: >
+          If true, we will enable user to use the unified ads API
+        type: Boolean
+        default: false
+    defaults:
+      - channel: beta
+        value:
+          enabled: false
+      - channel: developer
+        value:
+          enabled: false
diff --git a/firefox-ios/nimbus.fml.yaml b/firefox-ios/nimbus.fml.yaml
@@ -43,4 +43,5 @@ include:
   - nimbus-features/toolbarRefactorFeature.yaml
   - nimbus-features/tosFeature.yaml
   - nimbus-features/trackingProtectionRefactor.yaml
+  - nimbus-features/unifiedAds.yaml
   - nimbus-features/zoomFeature.yaml