Skip to content

Commit

Permalink
Refactor FXIOS-7338 [v119] update copy for the fakespot settings card (
Browse files Browse the repository at this point in the history
…#16547)

* Refactor FXIOS-7338 [v119] update copy for the fakespot settings card (#16268)

* addressed PR comments

* updated button text color

---------

Co-authored-by: Stefan Vladut <[email protected]>
  • Loading branch information
petruSt24 and Stefan Vladut authored Sep 25, 2023
1 parent 94b7941 commit ab45b02
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public class CollapsibleCardView: ShadowCardView, UIGestureRecognizerDelegate {

lazy var titleLabel: UILabel = .build { label in
label.adjustsFontForContentSizeCategory = true
label.font = DefaultDynamicFontHelper.preferredFont(withTextStyle: .headline, size: 17.0)
label.font = DefaultDynamicFontHelper.preferredBoldFont(withTextStyle: .subheadline, size: 15.0)
label.numberOfLines = 0
}

Expand Down
4 changes: 2 additions & 2 deletions Client/Frontend/Fakespot/Views/FakespotSettingsCardView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class FakespotSettingsCardViewModel {
final class FakespotSettingsCardView: UIView, ThemeApplicable {
private struct UX {
static let headerLabelFontSize: CGFloat = 17
static let buttonLabelFontSize: CGFloat = 17
static let buttonLabelFontSize: CGFloat = 16
static let buttonCornerRadius: CGFloat = 14
static let buttonLeadingTrailingPadding: CGFloat = 8
static let buttonTopPadding: CGFloat = 16
Expand Down Expand Up @@ -217,7 +217,7 @@ final class FakespotSettingsCardView: UIView, ThemeApplicable {
recommendedProductsSwitch.tintColor = colors.formKnob

turnOffButton.backgroundColor = colors.actionSecondary
turnOffButton.setTitleColor(colors.textPrimary, for: .normal)
turnOffButton.setTitleColor(colors.textOnLight, for: .normal)

footerView.applyTheme(theme: theme)
}
Expand Down
2 changes: 1 addition & 1 deletion Client/Frontend/Strings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3710,7 +3710,7 @@ extension String {
public static let SettingsCardTurnOffButton = MZLocalizedString(
key: "", // Shopping.SettingsCard.TurnOff.Buttton.v118
tableName: "Shopping",
value: "Turn Off Review Quality Check",
value: "Turn Off Review Checker",
comment: "Label of the button from settings card displayed in the shopping review quality bottom sheet.")
public static let SettingsCardExpandedAccessibilityLabel = MZLocalizedString(
key: "", // Shopping.SettingsCard.Expanded.AccessibilityLabel.v118
Expand Down

0 comments on commit ab45b02

Please sign in to comment.