Bugfix FXIOS-10277 [Toolbar redesign] Remove location view a11y label (…

…#22546) remove location text field a11y label
mozilla-mobile · Oct 15, 2024 · a0952e8 · a0952e8
1 parent e230676
commit a0952e8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/BrowserKit/Sources/ToolbarKit/AddressToolbar/LocationView/LocationView.swift b/BrowserKit/Sources/ToolbarKit/AddressToolbar/LocationView/LocationView.swift
@@ -399,7 +399,6 @@ final class LocationView: UIView, LocationTextFieldDelegate, ThemeApplicable, Ac
         lockIconButton.accessibilityLabel = state.lockIconButtonA11yLabel
 
         urlTextField.accessibilityIdentifier = state.urlTextFieldA11yId
-        urlTextField.accessibilityLabel = state.urlTextFieldA11yLabel
     }
 
     func accessibilityCustomActionsForView(_ view: UIView) -> [UIAccessibilityCustomAction]? {

diff --git a/BrowserKit/Sources/ToolbarKit/AddressToolbar/LocationView/LocationViewState.swift b/BrowserKit/Sources/ToolbarKit/AddressToolbar/LocationView/LocationViewState.swift
@@ -13,7 +13,6 @@ public struct LocationViewState {
 
     public let urlTextFieldPlaceholder: String
     public let urlTextFieldA11yId: String
-    public let urlTextFieldA11yLabel: String
 
     public let searchEngineImage: UIImage?
     public let lockIconImageName: String?
@@ -33,7 +32,6 @@ public struct LocationViewState {
         lockIconButtonA11yLabel: String,
         urlTextFieldPlaceholder: String,
         urlTextFieldA11yId: String,
-        urlTextFieldA11yLabel: String,
         searchEngineImage: UIImage?,
         lockIconImageName: String?,
         url: URL?,
@@ -51,7 +49,6 @@ public struct LocationViewState {
         self.lockIconButtonA11yLabel = lockIconButtonA11yLabel
         self.urlTextFieldPlaceholder = urlTextFieldPlaceholder
         self.urlTextFieldA11yId = urlTextFieldA11yId
-        self.urlTextFieldA11yLabel = urlTextFieldA11yLabel
         self.searchEngineImage = searchEngineImage
         self.lockIconImageName = lockIconImageName
         self.url = url

diff --git a/firefox-ios/Client/Frontend/Browser/Toolbars/Models/AddressToolbarContainerModel.swift b/firefox-ios/Client/Frontend/Browser/Toolbars/Models/AddressToolbarContainerModel.swift
@@ -45,7 +45,6 @@ class AddressToolbarContainerModel: Equatable {
             lockIconButtonA11yLabel: .AddressToolbar.PrivacyAndSecuritySettingsA11yLabel,
             urlTextFieldPlaceholder: .AddressToolbar.LocationPlaceholder,
             urlTextFieldA11yId: AccessibilityIdentifiers.Browser.AddressToolbar.searchTextField,
-            urlTextFieldA11yLabel: .AddressToolbar.LocationA11yLabel,
             searchEngineImage: searchEngineImage,
             lockIconImageName: lockIconImageName,
             url: url,

diff --git a/firefox-ios/Client/Frontend/Strings.swift b/firefox-ios/Client/Frontend/Strings.swift
@@ -6485,11 +6485,6 @@ extension String {
             tableName: "AddressToolbar",
             value: "Search or enter address",
             comment: "Placeholder for the address field in the address toolbar.")
-        public static let LocationA11yLabel = MZLocalizedString(
-            key: "AddressToolbar.Location.A11y.Label.v128",
-            tableName: "AddressToolbar",
-            value: "Search or enter address",
-            comment: "Accessibility label for the address field in the address toolbar.")
         public static let SearchEngineA11yLabel = MZLocalizedString(
             key: "AddressToolbar.SearchEngine.A11y.Label.v128",
             tableName: "AddressToolbar",
@@ -7399,6 +7394,13 @@ extension String {
                 value: nil,
                 comment: "Accessiblity hint for toggling on/off private mode")
         }
+        struct v133 {
+            public static let LocationA11yLabel = MZLocalizedString(
+                key: "AddressToolbar.Location.A11y.Label.v128",
+                tableName: "AddressToolbar",
+                value: "Search or enter address",
+                comment: "Accessibility label for the address field in the address toolbar.")
+        }
     }
 }