Document FXIOS-10334 ToDo's for forthcoming JS alert refactors (#22662)

Add ToDo comments per 10/18 incident reverts and related FXIOS-10334 ticket
mozilla-mobile · Oct 21, 2024 · 981c08f · 981c08f
1 parent fa7ef1c
commit 981c08f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/...end/Browser/BrowserViewController/Extensions/BrowserViewController+WebViewDelegates.swift b/...end/Browser/BrowserViewController/Extensions/BrowserViewController+WebViewDelegates.swift
@@ -62,13 +62,15 @@ extension BrowserViewController: WKUIDelegate {
             logger.log("Javascript message alert will be presented.", level: .info, category: .webview)
 
             present(messageAlert.alertController(), animated: true) {
+                // TODO: [FXIOS-10334] This should be called when the alert is dismissed, not presented
                 completionHandler()
                 self.logger.log("Javascript message alert was completed.", level: .info, category: .webview)
             }
         } else if let promptingTab = tabManager[webView] {
             logger.log("Javascript message alert is queued.", level: .info, category: .webview)
 
             promptingTab.queueJavascriptAlertPrompt(messageAlert)
+            // TODO: [FXIOS-10334] This should be called when the alert is dismissed, not enqueued
             completionHandler()
         }
     }

diff --git a/firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift b/firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
@@ -1029,6 +1029,7 @@ class BrowserViewController: UIViewController,
         // Ensure the layout is updated immediately
         view.layoutIfNeeded()
 
+        // TODO: [FXIOS-10334] Needs investigation. Dequeuing JS alerts as part of subview layout is problematic.
         showQueuedAlertIfAvailable()
         switchToolbarIfNeeded()
         adjustURLBarHeightBasedOnLocationViewHeight()