fix: only ping swift when section is valid

mozilla-mobile · Oct 8, 2024 · 33728c1 · 33728c1
1 parent 42301f0
commit 33728c1
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/firefox-ios/Client/Assets/CC_Script/FormAutofillChild.ios.sys.mjs b/firefox-ios/Client/Assets/CC_Script/FormAutofillChild.ios.sys.mjs
@@ -110,6 +110,13 @@ export class FormAutofillChild {
       return;
     }
 
+    // Since iOS doesn't support cross frame autofill,
+    // we should only call the autofill callback if the section is valid.
+    // TODO(issam): This will change when we have cross frame fill support.
+    if (!this.activeSection.isValidSection()) {
+      return;
+    }
+
     const fieldNamesWithValues = this.transformToFieldNamesWithValues(
       this.activeSection.fieldDetails
     );