Skip to content

Commit

Permalink
Bugfix FXIOS-7818 [v120.1] Reduce the number of sentry errors (#17433) (
Browse files Browse the repository at this point in the history
#17435)

(cherry picked from commit 2f991d2)

Co-authored-by: OrlaM <[email protected]>
  • Loading branch information
mergify[bot] and OrlaM authored Nov 22, 2023
1 parent d004679 commit 23869f9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 2 additions & 3 deletions BrowserKit/Sources/Common/Logger/DefaultLogger.swift
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ public class DefaultLogger: Logger {
crashManager?.setup(sendUsageData: sendUsageData)
}

public func logCustomError(error: Error) {
crashManager?.captureError(error: error)
}
// TODO: FXIOS-7819 need to rethink if this should go to Sentry
public func logCustomError(error: Error) {}

public func log(_ message: String,
level: LoggerLevel,
Expand Down
3 changes: 2 additions & 1 deletion Providers/RustErrors.swift
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ internal class ForwardOnLog: AppServicesLogger {
case .warn:
return LoggerLevel.warning
case .error:
return LoggerLevel.fatal
// TODO: FXIOS-7819 need to rethink if this should go to Sentry, setting as warning to bypass for now
return LoggerLevel.warning
}
}
}

1 comment on commit 23869f9

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

InterpreterError at template.tasks[0].extra[0].treeherder[1].symbol: unknown context value cron

Please sign in to comment.