Easier access to state valuations, choice labels and choice origins #180
Conversation
| @@ -13,7 +13,8 @@ void define_state(py::module& m, std::string const& vtSuffix) { | |||
| py::class_<SparseModelState<ValueType>>(m, ("Sparse" + vtSuffix + "ModelState").c_str(), "State in sparse model") | |||
| .def("__str__", &SparseModelState<ValueType>::toString) | |||
| .def_property_readonly("id", &SparseModelState<ValueType>::getIndex, "Id") | |||
| .def_property_readonly("labels", &SparseModelState<ValueType>::getLabels, "Labels") | |||
| .def_property_readonly("labels", &SparseModelState<ValueType>::getLabels, "Get state labels") | |||
| .def_property_readonly("valuations", &SparseModelState<ValueType>::getValuations, "Get state valuations") | |||
There was a problem hiding this comment.
Wasnt there something that this is superslow as it creates a copy?
There was a problem hiding this comment.
Can you elaborate what exactly makes it superslow? The readonly or the general implementation of the functions getLabels?
In general, the iteration over states / actions can certainly be improved peformance-wise. One issue for instance is that we have to keep track of the model. Maybe we open a separate issue for the performance and discuss options there?
There was a problem hiding this comment.
Ah, I misread it initially as if it was generating a copy of the complete state valuations everytime. That does not seem to happen. So indeed, we can merge it. We may want to discuss elsewhere whether we want to move the iteration over states with this slower high-level API to the stormvogel api.
|
LGTM. Sorry for the confusion, many thanks for the contribution. |
Allows to access labels, valuations and origins while iterating over states and actions.
Resolves #178