Add bindings for the Smg class #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Is there a way to create an SMG inside stormpy, e.g., via the components? Would be great if you could add a small test case for this to ensure that we do not break things in the future. (Maybe in tests/storage/...)? |
|
I haven't tried building the model in StormPy, but I will take a look! I will also add a test. |
|
I added a small test case for constructing SMG from sparse model components! |
|
Great. Once the tests finish, I will merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all the needed bindings for the Smg class.
Also fixed SparseModelComponents binding wrong property as 'player1_matrix'.