-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bindings for quantitative POMDP analysis #125
Conversation
Depends on moves-rwth/storm#396 |
print(result.lower_bound) | ||
print(result.upper_bound) | ||
print(result.induced_mc_from_scheduler) | ||
print(result.cutoff_schedulers[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace the print
statements by assert
? Then we can actually test the correctness.
Hi everyone, can we work on getting this merged? moves-rwth/storm#396 is already merged and we updated PAYNT to work with Storm 1.8 so it would be nice to have SAYNT fully operational with updated Storm/StormPy/PAYNT. |
Sorry, I think I somehow missed this completely. I adjusted the tests and merged the latest state of main, so let's see if this works. |
Many thanks for your prompt response :-) |
Thanks for integrating my comments. |
If I understand that correctly, the test runs using the stable branch of Storm. The include is already fixed in the latest Storm version, so isn't it necessary to release a new stable version containing the fix? Or can I change the required Storm version to a certain commit? If so, can you give me a pointer how this is done? |
Ah sorry, the error is in Storm and not stormpy. You need to increase the required Storm version here and set it to 1.8.2. |
Thanks everyone for a quick resolution of this! |
Introduction of bindings in accordance with the reworked quantitative POMDP analysis in Storm 1.8.
This is largely based on the work @TheGreatfpmK and @randriu did for the Storm-PAYNT POMDP integration (SAYNT).