Unified ssh config declaration and handling #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soraxas
force-pushed
the
feat-unified-ssh-conf
branch
2 times, most recently
from
a1b8200
to
fc322a8
Compare
Signed-off-by: Tin Lai <[email protected]>
soraxas
force-pushed
the
feat-unified-ssh-conf
branch
from
fc322a8
to
a1f29b9
Compare
|
@moul Can we review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pretty much unified the location of declaring all SSH config value that are simply passthrough.
This is achieved by reflection on struct field name and its datatype, plus custom struct tag to denote how to handle some of the range fields.
So that when there are new ssh config value, you only need to add a new line accordingly in the
struct Host {...}