MOSIP-23962 Db lock added to idgen batch ops #1377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwa-vyom
requested changes
Sep 22, 2022
| @@ -122,14 +133,14 @@ public void expireAndRelease() { | |||
|
|
|||
| private void expireEligibleVids() { | |||
| List<VidAssignedEntity> vidAssignedEntities = vidAssignedRepository | |||
| .findByStatusAndIsDeletedFalse(VidLifecycleStatus.ASSIGNED); | |||
| .findByStatusAndIsDeletedFalse(VidLifecycleStatus.ASSIGNED,vidExpireLimit); | |||
There was a problem hiding this comment.
Since this is about expiry and there is no sorting, if we add limit will it not create issues like taking more time to expire when there are large no of rows ? What is the frequency of this job ?
There was a problem hiding this comment.
yes it will take some time to expire. frequency is per day at 11 PM. But they can increase freq and limit or should we remove limit as we will scan and expire all in case eligible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.