Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated formats, update reader and writer backends #1191
Remove deprecated formats, update reader and writer backends #1191
Changes from 44 commits
0b0f0b6
e65c823
90c42dd
8fd26d4
90d77b6
dda2160
904eba7
b42fd4c
afa108f
9b2536a
7602f35
99e8146
1ed5413
a36825a
5079233
11b385e
8c417bf
98ac3c3
aa3e726
6f82f71
95ab814
4edad91
bc06bec
b8b123b
1767c84
fb25fe4
47d8012
595455c
b4d333a
3b02288
2d148d3
885daee
06c3c59
053310a
af08a07
5a60080
955d999
f5bdaf6
b358ca4
d24c889
b625c6b
e51631b
d50d101
e42cd01
ef0b34f
bbffe82
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to pass the following conversion mapping in the documentation. Then we just link to
mbuild/mbuild/conversion.py
Line 936 in e42cd01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. This should be done, along with the other suggestions.
Check warning on line 3224 in mbuild/compound.py
Codecov / codecov/patch
mbuild/compound.py#L3224