Replace setup.py with pyproject.toml, update actions to latest versions
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
- Coverage 94.07% 89.86% -4.21%
==========================================
Files 65 65
Lines 6953 6976 +23
==========================================
- Hits 6541 6269 -272
- Misses 412 707 +295 ☔ View full report in Codecov by Sentry. |
|
The failing bleeding edge test is related to this issue. Haven't had a chance to take a look yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Same as the PR made over in mBuild mosdef-hub/mbuild#1217
It's recommended to use
pyproject.tomlinstead ofsetup.pyand gets rid of the deprecation error when runningpip install .inside the repo.