Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support/testing for py3.8 #781

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

daico007
Copy link
Member

Relate to #778. I think it's time to drop 3.8 from the testing cycle.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5601c8) 92.82% compared to head (15a0065) 92.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #781   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files          66       66           
  Lines        6845     6845           
=======================================
  Hits         6354     6354           
  Misses        491      491           
Files Coverage Δ
gmso/external/convert_parmed.py 94.44% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daico007 daico007 merged commit b728c99 into mosdef-hub:main Oct 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants