Attempt to unpin some of our dependencies #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just about to make a PR to change the version of unyt to the latest :) Should we unpin these, or re-pin them to the latest versions? It would be great to incorporate something like dependabot, but from what I could tell, I don't think it currently works with anaconda .yml files? |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 66 66
Lines 6733 6733
=======================================
Hits 6187 6187
Misses 546 546 ☔ View full report in Codecov by Sentry. |
|
Pinning them to the latest versions (probably with |
This was referenced Sep 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local testing indicates that our tests run fine with the later version of numpy and unyt (?). I am not sure what changes might have happened upstream, but I think it's probably good time to unpin those packages.