Add performance checks #539
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 92.82% 88.67% -4.16%
==========================================
Files 66 56 -10
Lines 6845 4415 -2430
==========================================
- Hits 6354 3915 -2439
- Misses 491 500 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This is awesome and I think we should implement something similar in other mosdef packages. :)
I wonder if there is a way to implement something like pytest-profiling to check if a test is slower/faster from one commit to the next? 🤔 Just a thought!
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @pytest.mark.timeout(20) | ||
| def test_from_mbuild_performance(self, n_ar_system): | ||
| cmpd = n_ar_system(n_sites=50000) | ||
| top = from_mbuild(cmpd) |
Check notice
Code scanning / CodeQL
Unused local variable
| @@ -0,0 +1,48 @@ | |||
| import pytest | |||
|
|
|||
| from gmso.core.atom import Atom | |||
Check notice
Code scanning / CodeQL
Unused import
| import pytest | ||
|
|
||
| from gmso.core.atom import Atom | ||
| from gmso.core.atom_type import AtomType |
Check notice
Code scanning / CodeQL
Unused import
|
|
||
| from gmso.core.atom import Atom | ||
| from gmso.core.atom_type import AtomType | ||
| from gmso.core.topology import Topology |
Check notice
Code scanning / CodeQL
Unused import
Addresses #473. The tests mostly check that writers are performant; the system size and timeout values could probably be tweaked, I based them off simple profiling I did with
time.I also made a note to check loading a FF XML once #521 is addressed. Should also add checks once foyer integrations is accomplished.
I'm open to any other suggestions for tests we could add.