Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DistributedSampler RNG seed argument #3724

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

janEbert
Copy link
Contributor

This way, it becomes easier to randomly vary the order of the data.

What does this PR do?

Exposes the DistributedSampler's seed argument in the get_sampler utility function. Since the default value is already seed=0, #3723.

What issue(s) does this change relate to?

Fixes #3723

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@mvpatel2000

This way, it becomes easier to randomly vary the order of the data.
janEbert added a commit to janEbert/llm-foundry that referenced this pull request Nov 26, 2024
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvpatel2000 mvpatel2000 merged commit 23e6a2e into mosaicml:main Nov 28, 2024
15 checks passed
janEbert added a commit to janEbert/llm-foundry that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DistributedSampler seeding
3 participants