Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mosaicml/pytorch images to use new mosaicml/pytorch images with updated ubuntu 22.04 #3718

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Bump mosaicml/pytorch images to use new mosaicml/pytorch images with updated ubuntu 22.04 #3718

merged 2 commits into from
Nov 20, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Nov 20, 2024 •
edited
Loading

What does this PR do?

Bumps all images in composer to now use 22.04, follow up for #3716

What issue(s) does this change relate to?

https://databricks.atlassian.net/jira/software/c/projects/GRT/boards/4746?selectedIssue=GRT-3195

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@KuuCi KuuCi requested a review from a team as a code owner November 20, 2024 19:27
@KuuCi KuuCi marked this pull request as draft November 20, 2024 19:27
@KuuCi KuuCi marked this pull request as ready for review November 20, 2024 19:46
snarayan21
snarayan21 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm. needs approval from a code owner though @mvpatel2000 @dakinggg

dakinggg
dakinggg reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run the daily tests against this pr so we can be sure all the ci you are changing passes before merging?

@KuuCi KuuCi merged commit c830295 into main Nov 20, 2024
14 checks passed
@KuuCi KuuCi deleted the mosaicml-pytorch-20.04 branch November 20, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@snarayan21 snarayan21 snarayan21 approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

@b-chu b-chu Awaiting requested review from b-chu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KuuCi @snarayan21 @dakinggg