Remove unnecessary pad token #2428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
Aug 19, 2023
| batch = { | ||
| 'input_ids': torch.stack(inputs), | ||
| 'input_ids': input_ids, |
There was a problem hiding this comment.
I believe the test error you are getting is because input_ids and labels should not be the same tensor, because labels gets modified to put a -100 when the labels get rolled so they are aligned for the next token objective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of padding till max_seq_len, use the maximum length of the batch.
I have provided a simple and concise solution.
What issue(s) does this change relate to?