Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EBCDIC1047 prefixer description #333

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

Inuart
Copy link
Contributor

@Inuart Inuart commented Oct 26, 2024

I believe the EBCDIC1047 prefixer should have its own Inspect description, different from EBCDIC.

Verified

This commit was signed with the committer’s verified signature.
Inuart Eduard Castany
@Inuart Inuart requested a review from alovak as a code owner October 26, 2024 22:25
@alovak
Copy link
Contributor

alovak commented Oct 27, 2024

@Inuart thanks for the change! Would you be able to fix the tests?

Verified

This commit was signed with the committer’s verified signature.
Inuart Eduard Castany
@Inuart
Copy link
Contributor Author

Inuart commented Oct 27, 2024

@Inuart thanks for the change! Would you be able to fix the tests?

Done! Sorry, I forgot about the tests

@alovak alovak merged commit 8c09e82 into moov-io:master Oct 27, 2024
8 checks passed
@Inuart Inuart deleted the ebcdic1047_prefixer_description branch October 28, 2024 10:56
@alovak
Copy link
Contributor

alovak commented Oct 28, 2024

@Inuart it was released in https://github.com/moov-io/iso8583/releases/tag/v0.22.2

thanks a lot for the fix!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants