Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial unpack #300

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Partial unpack #300

merged 6 commits into from
Nov 30, 2023

Conversation

meparle
Copy link
Contributor

@meparle meparle commented Nov 21, 2023

  1. Return a partially unpacked message if there is an error during unpack()
  2. Add Field to UnpackError to indicate in which field the error occurred without needing to retrieve from within the error message

@meparle meparle requested a review from alovak as a code owner November 21, 2023 16:33
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8f4cb18) 74.85% compared to head (aadd842) 74.86%.

❗ Current head aadd842 differs from pull request most recent head 03ff030. Consider uploading reports for the commit 03ff030 to get more accurate results

Files Patch % Lines
message.go 80.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   74.85%   74.86%   +0.01%     
==========================================
  Files          44       44              
  Lines        2494     2495       +1     
==========================================
+ Hits         1867     1868       +1     
  Misses        411      411              
  Partials      216      216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alovak alovak merged commit 231e13d into moov-io:master Nov 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants