Update message unimarshaller functions #291

mfdeveloper508 · 2023-10-05T13:38:18Z

codecov-commenter · 2023-10-05T13:40:47Z

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ec6abff) 74.91% compared to head (a257d96) 74.75%.

❗ Current head a257d96 differs from pull request most recent head 1103771. Consider uploading reports for the commit 1103771 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   74.91%   74.75%   -0.17%     
==========================================
  Files          43       43              
  Lines        2436     2452      +16     
==========================================
+ Hits         1825     1833       +8     
- Misses        389      396       +7     
- Partials      222      223       +1

Files	Coverage Δ
message.go	`74.13% <71.42%> (+0.02%)`	⬆️
field/composite.go	`78.70% <57.14%> (-1.43%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

field/composite.go

message.go

message_test.go

alovak · 2023-10-05T14:03:46Z

It looks good! Would you please add table tests for Marshal/Unmarshal something like this: https://github.com/moov-io/iso8583/blob/2f44c9f5c9bf72927313d35e4dfaa478711943fb/exp_test.go?

message.go

mfdeveloper508 · 2023-10-05T15:11:21Z

I will append exp_test.go in next pr

alovak · 2023-10-05T15:37:41Z

field/string.go

@@ -153,7 +153,7 @@ func (f *String) Unmarshal(v interface{}) error {
 }

 func (f *String) Marshal(v interface{}) error {
-	if v == nil || reflect.ValueOf(v).IsZero() {
+	if v == nil || (!reflect.ValueOf(v).CanInt() && reflect.ValueOf(v).IsZero()) {


When we add keepzero we should check if value is 0 (int/*int) for field.String, then we should assign it.

Also, it may be similar to some other types. Not sure.

right
the code is exception for having int value zero

Update message.Marshal message to accept structs with go's native types

cc051aa

mfdeveloper508 requested a review from alovak as a code owner October 5, 2023 13:38

update comment

dc61226

mfdeveloper508 requested a review from wadearnold October 5, 2023 13:42