Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating unimarshaller #289

Merged
merged 14 commits into from
Oct 5, 2023
Merged

Updating unimarshaller #289

merged 14 commits into from
Oct 5, 2023

Conversation

mfdeveloper508
Copy link
Contributor

@mfdeveloper508 mfdeveloper508 requested a review from alovak as a code owner October 2, 2023 15:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (b652df4) 73.70% compared to head (2cb0e9d) 73.60%.
Report is 3 commits behind head on master.

❗ Current head 2cb0e9d differs from pull request most recent head a88931a. Consider uploading reports for the commit a88931a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   73.70%   73.60%   -0.10%     
==========================================
  Files          43       43              
  Lines        2282     2478     +196     
==========================================
+ Hits         1682     1824     +142     
- Misses        369      413      +44     
- Partials      231      241      +10     
Files Coverage Δ
test/fuzz-reader/reader.go 55.55% <0.00%> (ø)
field/bitmap.go 69.29% <60.00%> (-1.76%) ⬇️
field/track1.go 69.02% <40.00%> (ø)
field/track2.go 68.22% <40.00%> (ø)
field/track3.go 61.79% <40.00%> (ø)
message.go 74.10% <91.83%> (+2.15%) ⬆️
field/composite.go 80.13% <85.36%> (-1.76%) ⬇️
field/hex.go 72.72% <71.15%> (+4.18%) ⬆️
field/string.go 76.72% <67.92%> (-6.41%) ⬇️
field/binary.go 65.07% <66.66%> (+4.40%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alovak alovak changed the base branch from master to emv October 2, 2023 17:25
@alovak alovak changed the base branch from emv to master October 2, 2023 17:26
field/binary.go Outdated Show resolved Hide resolved
field/binary.go Outdated Show resolved Hide resolved
field/binary.go Outdated Show resolved Hide resolved
field/binary.go Outdated Show resolved Hide resolved
field/binary.go Outdated Show resolved Hide resolved
field/binary.go Outdated Show resolved Hide resolved
field/binary.go Show resolved Hide resolved
mfdeveloper508 and others added 4 commits October 2, 2023 13:54
Co-authored-by: Pavel Gabriel <[email protected]>
Co-authored-by: Pavel Gabriel <[email protected]>
Co-authored-by: Pavel Gabriel <[email protected]>
Co-authored-by: Pavel Gabriel <[email protected]>
field/binary.go Show resolved Hide resolved
field/binary_test.go Outdated Show resolved Hide resolved
@alovak alovak changed the base branch from master to v0.21.0-preview October 4, 2023 20:05
@alovak alovak deleted the branch master October 4, 2023 20:06
@alovak alovak closed this Oct 4, 2023
@alovak alovak reopened this Oct 4, 2023
@alovak alovak changed the base branch from v0.21.0-preview to master October 4, 2023 20:07
Copy link
Contributor

@alovak alovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@alovak alovak merged commit ec6abff into master Oct 5, 2023
9 checks passed
@alovak alovak deleted the issue-282 branch October 5, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants