update comment

moov-io · Oct 5, 2023 · dc61226 · dc61226
1 parent cc051aa
commit dc61226
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/field/composite.go b/field/composite.go
@@ -206,12 +206,14 @@ func (f *Composite) Unmarshal(v interface{}) error {
 				return fmt.Errorf("failed to get data from field %s: %w", indexOrTag, err)
 			}
 		default: // Native types
-			vv := reflect.New(dataField.Type()).Elem()
-			err = messageField.Unmarshal(vv)
+			// using new reflect value that has pointer instead of input data field
+			dummy := reflect.New(dataField.Type()).Elem()
+			err = messageField.Unmarshal(dummy)
 			if err != nil {
 				return fmt.Errorf("failed to get data from field %s: %w", indexOrTag, err)
 			}
-			dataField.Set(vv)
+
+			dataField.Set(dummy)
 		}
 	}
 

diff --git a/message.go b/message.go
@@ -513,12 +513,14 @@ func (m *Message) Unmarshal(v interface{}) error {
 				return fmt.Errorf("failed to get value from field %d: %w", fieldIndex, err)
 			}
 		default: // Native types
-			vv := reflect.New(dataField.Type()).Elem()
-			err = messageField.Unmarshal(vv)
+			// using new reflect value that has pointer instead of input data field
+			dummy := reflect.New(dataField.Type()).Elem()
+			err = messageField.Unmarshal(dummy)
 			if err != nil {
 				return fmt.Errorf("failed to get value from field %d: %w", fieldIndex, err)
 			}
-			dataField.Set(vv)
+
+			dataField.Set(dummy)
 		}
 	}