Adding External Screen Support [Feature Request #11] #411

mattrussell7 · 2020-05-20T07:26:39Z

Added External Screen Support for all iOS devices whether through HDMI Out via Lightning/USB-C or Airplay Screen Mirroring.

Feature Request #11 discusses this.

Limelight/ViewControllers/StreamFrameViewController.m

cgutman · 2020-05-21T02:31:21Z

Limelight/ViewControllers/StreamFrameViewController.m

@@ -61,8 +90,9 @@ - (void)viewDidLoad

    _controllerSupport = [[ControllerSupport alloc] initWithConfig:self.streamConfig presenceDelegate:self];
    _inactivityTimer = nil;
-
+    _renderView = (StreamView*)[[UIView alloc] initWithFrame:self.view.frame];


It's not safe to cast a UIView to a StreamView.

@cgutman What would you suggest to be a better alternative? Should it be a split to a #IF os(iOS)? Is this due to StreamView being a possible OSView for non iOS devices?

cgutman · 2020-05-21T02:31:51Z

Limelight/ViewControllers/StreamFrameViewController.m

+    if (UIScreen.screens.count > 1) {
+          [self prepExtScreen:UIScreen.screens.lastObject];
+      }
+    else {


Looks like the indentation got a bit mangled here

tristan-k · 2020-12-29T02:48:11Z

Will this be merged anytime soon?

jasonmp85 · 2021-04-18T23:33:06Z

What does this need to be merged? I hate playing in pillarbox on my TV, which is pretty much my main use case for this app

tristan-k · 2021-07-05T14:33:07Z

Still waiting for this one. Steam Link already does this albeit with black bars due to the aspect ratio of iPads.

stale · 2022-01-08T23:08:57Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

jasonmp85 · 2022-01-20T18:02:49Z

Ping to keep from closing.

marinobantli · 2022-03-01T19:45:43Z

Hello, I started working on this and got it to work for now. However, I've never coded in objective C before and there is some potential to optimize or better ways to solve it for sure.

For now, when you connect an external Display, it will automatically move the stream to the external screen in its native resolution and the iPad only shows a black screen (or the statistics overlay if you enabled it). If you unplug the monitor, it will move to the iPad screen again.

However, at the moment, i don't get it to work above 60Hz...

tristan-k · 2022-03-09T14:12:11Z

@marinobantli Do you have a IPA binary available for testing?

jasonmp85 · 2022-03-09T23:38:36Z

I've no Obj-C experience either, but give me an app and what I can do to get logs or debugging or whatever and I'll gladly help out.

ReclusiveRychuRychu · 2022-03-11T20:02:06Z

Hello, I started working on this and got it to work for now. However, I've never coded in objective C before and there is some potential to optimize or better ways to solve it for sure.

For now, when you connect an external Display, it will automatically move the stream to the external screen in its native resolution and the iPad only shows a black screen (or the statistics overlay if you enabled it). If you unplug the monitor, it will move to the iPad screen again.

However, at the moment, i don't get it to work above 60Hz...

This sounds amazing! and exactly what Moonlight needs. Can any devs implement this?

marinobantli · 2022-03-16T06:32:58Z

Sorry for the silence, as of now, the external screen works, but I can't get mouse scrolling and keyboard inputs to work on the external screen. Controller input works however.

I would like to implement a little "dashboard" which is displayed on the iPads screen whenever an external display is connected to be able to change the external resolution.

ReclusiveRychuRychu · 2022-03-16T17:49:20Z

Sorry for the silence, as of now, the external screen works, but I can't get mouse scrolling and keyboard inputs to work on the external screen. Controller input works however.

I would like to implement a little "dashboard" which is displayed on the iPads screen whenever an external display is connected to be able to change the external resolution.

No apologies necessary! You're solving the final piece of the puzzle for my ideal set up! As a controller user this sounds like all I'd need, but obviously making sure everything works properly is important, and the added dashboard sounds like a lovely QoL improvement.

I'd love to see @cgutman help you with this and get it implemented in the next version!

jasonmp85 · 2022-03-23T23:08:33Z

To be clear, I need to take this branch, build it, and try it out?

gsaker · 2022-07-04T16:17:05Z

I would also love this feature to be added. Any updates?

perroboc · 2022-08-20T16:30:37Z

Ping! Just because I think this is a must 🙂

marinobantli · 2022-08-21T11:29:02Z

I will try to work on it again in a few weeks…
I’m absolutely new to Objective-C and what i have written so far will probably be obsolete / cleaner to code in the upcoming ipadOS 16 due to the new Stage Manager.

beitincapital · 2022-11-23T21:14:21Z

Hello - just wondering if anyone has made progress on this request? The feature would be an amazing addition to the iOS app.

git-nerd · 2022-12-22T17:22:56Z

It would be great if this feature did not depend on stage manager, because there are ipads that don’t all run stage manager (like ipad mini).

patroza · 2023-07-21T11:38:59Z

here's an updated fork that works https://github.com/patroza/moonlight-ios/pull/1/files

stage manager solutions are not useful for me because I dont have a pointing device like mouse connected to change the window to full screen on the external display. the external display is even just xreal air glasses.
so this solution is great as it functions similar to Apple TV, Netflix and steam link.

jeff08568 · 2023-07-22T11:05:05Z

Can I use your fork or do we have to wait for merge

patroza · 2023-07-22T11:39:38Z

Can I use your fork or do we have to wait for merge

Feel free

jeff08568 · 2023-07-23T17:18:47Z

Can confirm it’s working as expected. However when I locked my screen I noticed the image becomes static/stopped moving? Is this an iOS limitation?

patroza · 2023-07-23T17:24:56Z

Can confirm it’s working as expected. However when I locked my screen I noticed the image becomes static/stopped moving? Is this an iOS limitation?

Think so but unsure; how is the behavior with Netflix or TV app? Or Steam link

jeff08568 · 2023-07-23T17:39:37Z

Can confirm it’s working as expected. However when I locked my screen I noticed the image becomes static/stopped moving? Is this an iOS limitation?

Think so but unsure; how is the behavior with Netflix or TV app? Or Steam link

I’ve tested Netflix, Plex and nPlayer, they all seem to work fine with screen off. Not sure about steam link though, will test tomorrow

Edit: I’ve tested Steam link, it behaves exactly as your forked version. Not sure how apps like Netflix got around this, although I doubt you can send any controller signal to iOS with the screen locked.

patroza · 2023-07-24T08:45:47Z

I’ve tested Netflix, Plex and nPlayer, they all seem to work fine with screen off. Not sure about steam link though, will test tomorrow

Edit: I’ve tested Steam link, it behaves exactly as your forked version. Not sure how apps like Netflix got around this, although I doubt you can send any controller signal to iOS with the screen locked.

nice find! yea in my case I use controllers connected to my pc, so for me that would be fine. but I imagine for most other people it will be important.

mikicof · 2023-11-09T17:04:22Z

I'm very interested having this, can we go on with the PR?

amirlpro · 2024-04-14T10:28:25Z

Please prioritize this PR

yichengchen · 2024-05-04T12:08:08Z

any progress on this？I try merge the pr with the master branch and it works. If there are any necessary change need to do before merge, I am willing to help.

Rayray1099 · 2024-07-02T11:17:40Z

Any updates on the External Screen Support?

Write · 2024-11-04T08:43:33Z

Would love to see this too

added external screen support

a31ad07

mattrussell7 force-pushed the master branch from 082b0cf to a31ad07 Compare May 20, 2020 16:15

cgutman reviewed May 21, 2020

View reviewed changes

Limelight/ViewControllers/StreamFrameViewController.m Show resolved Hide resolved

cgutman reviewed May 21, 2020

View reviewed changes

stale bot added the stale label Aug 21, 2020

moonlight-stream deleted a comment from stale bot Aug 21, 2020

stale bot removed the stale label Aug 21, 2020

cgutman force-pushed the master branch from 7cbbdc9 to 5da55d8 Compare March 3, 2021 07:39

tristan-k mentioned this pull request Jul 5, 2021

Display out #383

Closed

stale bot added the stale label Jan 8, 2022

stale bot removed the stale label Jan 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding External Screen Support [Feature Request #11] #411

Adding External Screen Support [Feature Request #11] #411

mattrussell7 commented May 20, 2020

cgutman May 21, 2020

mattrussell7 May 22, 2020 •

edited

Loading

cgutman May 21, 2020

tristan-k commented Dec 29, 2020

jasonmp85 commented Apr 18, 2021

tristan-k commented Jul 5, 2021

stale bot commented Jan 8, 2022

jasonmp85 commented Jan 20, 2022

marinobantli commented Mar 1, 2022 •

edited

Loading

tristan-k commented Mar 9, 2022 •

edited

Loading

jasonmp85 commented Mar 9, 2022

ReclusiveRychuRychu commented Mar 11, 2022

marinobantli commented Mar 16, 2022

ReclusiveRychuRychu commented Mar 16, 2022 •

edited

Loading

jasonmp85 commented Mar 23, 2022

gsaker commented Jul 4, 2022

perroboc commented Aug 20, 2022

marinobantli commented Aug 21, 2022

beitincapital commented Nov 23, 2022

git-nerd commented Dec 22, 2022 •

edited

Loading

patroza commented Jul 21, 2023 •

edited

Loading

jeff08568 commented Jul 22, 2023

patroza commented Jul 22, 2023

jeff08568 commented Jul 23, 2023

patroza commented Jul 23, 2023 •

edited

Loading

jeff08568 commented Jul 23, 2023 •

edited

Loading

patroza commented Jul 24, 2023

mikicof commented Nov 9, 2023

amirlpro commented Apr 14, 2024

yichengchen commented May 4, 2024 •

edited

Loading

Rayray1099 commented Jul 2, 2024

Write commented Nov 4, 2024

Adding External Screen Support [Feature Request #11] #411

Are you sure you want to change the base?

Adding External Screen Support [Feature Request #11] #411

Conversation

mattrussell7 commented May 20, 2020

cgutman May 21, 2020

Choose a reason for hiding this comment

mattrussell7 May 22, 2020 • edited Loading

Choose a reason for hiding this comment

cgutman May 21, 2020

Choose a reason for hiding this comment

tristan-k commented Dec 29, 2020

jasonmp85 commented Apr 18, 2021

tristan-k commented Jul 5, 2021

stale bot commented Jan 8, 2022

jasonmp85 commented Jan 20, 2022

marinobantli commented Mar 1, 2022 • edited Loading

tristan-k commented Mar 9, 2022 • edited Loading

jasonmp85 commented Mar 9, 2022

ReclusiveRychuRychu commented Mar 11, 2022

marinobantli commented Mar 16, 2022

ReclusiveRychuRychu commented Mar 16, 2022 • edited Loading

jasonmp85 commented Mar 23, 2022

gsaker commented Jul 4, 2022

perroboc commented Aug 20, 2022

marinobantli commented Aug 21, 2022

beitincapital commented Nov 23, 2022

git-nerd commented Dec 22, 2022 • edited Loading

patroza commented Jul 21, 2023 • edited Loading

jeff08568 commented Jul 22, 2023

patroza commented Jul 22, 2023

jeff08568 commented Jul 23, 2023

patroza commented Jul 23, 2023 • edited Loading

jeff08568 commented Jul 23, 2023 • edited Loading

patroza commented Jul 24, 2023

mikicof commented Nov 9, 2023

amirlpro commented Apr 14, 2024

yichengchen commented May 4, 2024 • edited Loading

Rayray1099 commented Jul 2, 2024

Write commented Nov 4, 2024

mattrussell7 May 22, 2020 •

edited

Loading

marinobantli commented Mar 1, 2022 •

edited

Loading

tristan-k commented Mar 9, 2022 •

edited

Loading

ReclusiveRychuRychu commented Mar 16, 2022 •

edited

Loading

git-nerd commented Dec 22, 2022 •

edited

Loading

patroza commented Jul 21, 2023 •

edited

Loading

patroza commented Jul 23, 2023 •

edited

Loading

jeff08568 commented Jul 23, 2023 •

edited

Loading

yichengchen commented May 4, 2024 •

edited

Loading