Update moonwall to 5.9.1 and add --bail=1 #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make test failures faster
WASM runtime size check:Compared to target branchdancebox runtime: 1428 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2132 KB (+2132 KB) container chain template simple runtime: 1124 KB (-4296 KB) ✅ container chain template frontier runtime: 1400 KB (-5152 KB) ✅ |
Coverage Report@@ Coverage Diff @@
## master tomasz-update-moonwall2 +/- ##
==========================================================
Coverage 65.28% 65.28% 0.00%
Files 325 325
Lines 56845 56845
==========================================================
Hits 37109 37109
Misses 19736 19736
|
|
@tmpolaczyk What does |
Updated PR description |
ParthDesai
added
B0-silent
girazoki
added
the
D3-trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --bail=1 flag makes the tests stop on the first failure, as opposed to always executing all the tests. The zombie_data_preservers tests takes 40 minutes to fail because it waits for several tests to fail with timeout, with this it should fail in 10 minutes.
https://stackoverflow.com/a/78969381
Requires node 22