Add pallet_pooled_staking to Dancelight #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchdancebox runtime: 1428 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2132 KB (+2132 KB) container chain template simple runtime: 1124 KB (-4296 KB) ✅ container chain template frontier runtime: 1400 KB (-5152 KB) ✅ |
Coverage Report@@ Coverage Diff @@
## master tomasz-starlight-staking +/- ##
============================================================
+ Coverage 64.76% 65.28% +0.52%
+ Files 323 325 +2
+ Lines 55740 56845 +1105
============================================================
+ Hits 36097 37109 +1012
+ Misses 19643 19736 +93
|
tmpolaczyk
added
B7-runtimenoteworthy
nanocryk
approved these changes
Dec 5, 2024
ParthDesai
reviewed
Dec 6, 2024
ParthDesai
reviewed
Dec 6, 2024
|
Changes look good to me! Could we add at least one integration test to check the overall functioning of the pooled staking inside dancelight? |
|
And a description please @tmpolaczyk |
|
I separated the typescript tests to a new PR because they are not trivial, and not ready yet. #782 |
Agusrodri
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pallet_pooled_staking to Dancelight. Container chain collators will be selected first from invulnerables, and then from staking.