-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add [each_err] & [fold_err] API to [Iter] #765
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
/// - `f`: A function that takes an element of type `T` and returns `Unit`. | ||
/// This function is applied to each element of the iterator and may raise error of type `Err`. | ||
pub fn each_err[T, Err](self : Iter[T], f : (T) -> Unit!Err) -> Unit!Err { | ||
let mut err = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think eventually, we should just have only one each
function which accept the error callback, the optimizer should be able to generate as efficient code for callbacks without errors
cc @Yu-zh
Add two APIs,
each_err
andfold_err
to theIter
type. These two APIs are similar toeach
andfold
, except that the callback may raise an error. If the callback raises any error, the iteration stops immediately and raises the same error.