-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ✨ Create TS monorepo structure #3091
Conversation
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2248 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2248 KB (+236 KB compared to latest release) Moonriver runtime: 2240 KB (+228 KB compared to latest release) |
… feat/ts-monorepo
… feat/ts-monorepo
Coverage Report@@ Coverage Diff @@
## master feat/ts-monorepo +/- ##
===================================================
Coverage 74.58% 74.58% 0.00%
Files 375 375
Lines 95682 95682
===================================================
Hits 71359 71359
Misses 24323 24323
|
I think we should be able improve the reliability of the packages in some other way, having generated code committed is usually a bad practice. Cons:
Pros:
|
…nbeam into feat/ts-monorepo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but having dependencies using any version can be unstable. It will be fine if we no longer plan to publish the packages to npm
It's not using any dep version, it's fixed in the top level. We use * so that ALL sub projects use the SAME version to stop inconsistencies of the past from breaking publish |
What does it do?
Structures the TS packges of this repo so they share package versions and tooling. This will simplify releases by reducing the amount of steps.
What value does it bring to the blockchain users?
More frequent and reliable NPM packages