-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy loading improvements #3066
Conversation
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2248 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2248 KB (+236 KB compared to latest release) Moonriver runtime: 2240 KB (+228 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/lazy-loading-improvements4 +/- ##
=================================================================
- Coverage 74.58% 74.49% -0.09%
+ Files 375 376 +1
+ Lines 95681 95800 +119
=================================================================
Hits 71358 71358
+ Misses 24323 24442 +119
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does it do?
Improves the lazy-loading features and fixes a few bugs.
Improvements:
contextual_call
in the call executor; (Will move this another PR)Bugs:
Currently, when manually sealing a block, the finalize parameter needs to be false, otherwise the block will not be built