Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading improvements #3066

Merged
merged 9 commits into from
Jan 9, 2025
Merged

Lazy loading improvements #3066

merged 9 commits into from
Jan 9, 2025

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Dec 1, 2024

What does it do?

Improves the lazy-loading features and fixes a few bugs.

Improvements:

  • Increase the authoring deadline to 60 seconds

    Because lazy-loading fetches the storage from a remote node, sometimes, the authoring deadline to propose a block was not enough, causing some transactions to not be included in the block:
    DEBUG tokio-runtime-worker basic-authorship: [Lazy loading :last_quarter_moon:] Consensus deadline reached when pushing block transactions, proceeding with proposing.

  • Add support for proof recording when calling contextual_call in the call executor; (Will move this another PR)
  • Control the inherent data passed to inherents calls when building a block; (Will move this another PR)

Bugs:

  • Fix race condition when querying the storage (Could not reproduce yet)
  • Fix block finalization
    Currently, when manually sealing a block, the finalize parameter needs to be false, otherwise the block will not be built

@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes lazy-loading These changes affect the lazy loading feature labels Dec 1, 2024
@RomarQ RomarQ self-assigned this Dec 1, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2248 KB (no changes) ✅

Moonriver runtime: 2240 KB (no changes) ✅

Compared to latest release (runtime-3400)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2248 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2240 KB (+228 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Dec 1, 2024

Coverage Report

@@                        Coverage Diff                        @@
##           master   rq/lazy-loading-improvements4      +/-   ##
=================================================================
- Coverage   74.58%                          74.49%   -0.09%     
+ Files         375                             376       +1     
+ Lines       95681                           95800     +119     
=================================================================
  Hits        71358                           71358              
+ Misses      24323                           24442     +119     
Files Changed Coverage

Coverage generated Tue Dec 17 10:45:05 UTC 2024

@RomarQ RomarQ changed the title Increase authoring deadline to 60 seconds when using lazy loading Lazy loading improvements Dec 2, 2024
@RomarQ RomarQ marked this pull request as ready for review December 19, 2024 12:51
@RomarQ RomarQ requested review from TarekkMA and pLabarta December 19, 2024 12:52
@RomarQ
Copy link
Contributor Author

RomarQ commented Jan 9, 2025

@TarekkMA @pLabarta can any of you have a look at this PR?

Copy link
Contributor

@TarekkMA TarekkMA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomarQ RomarQ merged commit 3aea751 into master Jan 9, 2025
41 checks passed
@RomarQ RomarQ deleted the rq/lazy-loading-improvements4 branch January 9, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) lazy-loading These changes affect the lazy loading feature not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants