thanos-query-frontend: add --query-frontend.query-stats-enabled #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd like to better instrument which queries are pulling the most data out of Thanos. Tracing helps us dive into the detail, but we'd like to see samples touched at an overall level.
This uses the query-stats feature of thanos-query to append a &stats query parameter to queries, telling thanos-query to return a stats:{} field in the response, then logging the given stats. It is enabled by a --query-frontend.query-stats-enabled flag. Some of this code was originally ported over from cortex-query-frontend but as far as I can tell, never actually tested or used.
Signed-off-by: milesbryant <[email protected]>
domgoodwin
approved these changes
Oct 24, 2024
milesbxf
merged commit 0577661
into
monzo-master-v0.35.0-rc-0.65
10 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to better instrument which queries are pulling the most data out of Thanos. Tracing helps us dive into the detail, but we'd like to see samples touched at an overall level.
This uses the query-stats feature of thanos-query to append a &stats query parameter to queries, telling thanos-query to return a stats:{} field in the response, then logging the given stats. It is enabled by a --query-frontend.query-stats-enabled flag. Some of this code was originally ported over from cortex-query-frontend but as far as I can tell, never actually tested or used.
Changes
Verification