Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds autosave daemon thread that saves all loaded maps once a minute #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

factorsofx
Copy link

@factorsofx factorsofx commented Jul 6, 2017

I think I finally sorted out my git problems... Anyways, here's this. I synchronize on editor like the other place that iterates over the list of loaded maps. Sorry again for the spam!

@ghost
Copy link

ghost commented Dec 30, 2017

@monster860 merge it NAO

@ghost
Copy link

ghost commented Feb 22, 2018

What does this do? Does it autosave all the maps every minute? If so, why? What if you are working on something and you're not done yet?

@PJB3005
Copy link
Contributor

PJB3005 commented Feb 22, 2018

@HiddenKn you should ALWAYS save liberally even if you're not "done" yet. If the editor crashes or whatever you lose all your work.

@ghost
Copy link

ghost commented Feb 22, 2018

@PJB3005 I prefer to only save after I make an actual proper change. Autosave causes saves during unfinished changes resulting in useless "backups". Unless this saves to a different file than the main save? (For example, ·vim saves backup information to .swp files)

@PJB3005
Copy link
Contributor

PJB3005 commented Feb 22, 2018

How are these backups "useless"? If the program crashes and you have a backup 30 seconds ago you lost 30 seconds of work. If you don't have a backup you might've lost 30 minutes of work.

@ghost
Copy link

ghost commented Feb 22, 2018

And if you made a mistake you may have just lost over 30 minutes of work because your known good version was just overwritten by a broken version.

@PJB3005
Copy link
Contributor

PJB3005 commented Feb 23, 2018

That's what version control is for.

@ghost
Copy link

ghost commented Feb 23, 2018

Your workflow isn't the same as everyone else's. I've made my point if you disagree that's fine. I'm just saying it would be nice if it could be saved to a backup file or if there's a configuration option to disable it.

@PowerfulBacon
Copy link

What if im placing stuff on a map after I have finished and specifically don't want it to be saved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants