Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown age for babies #7184

Merged
merged 3 commits into from
Oct 27, 2024
Merged

fix: unknown age for babies #7184

merged 3 commits into from
Oct 27, 2024

Conversation

abdabdii
Copy link
Contributor

@abdabdii abdabdii commented Mar 9, 2024

"Unknown Age" for babies #7171 - fixed

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2024

CLA assistant check
All committers have signed the CLA.

@asbiin asbiin changed the title "Unknown Age" for babies fix: "Unknown Age" for babies Mar 16, 2024
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! See my comment :

@@ -10,7 +10,7 @@
<InertiaLink :href="data.url" class="text-gray-800 hover:underline dark:text-gray-200">{{
data.name
}}</InertiaLink>
<span v-if="data.age" class="text-gray-500">{{ data.age }}</span>
<span v-if="data.age || data.age === 0" class="text-gray-500">{{ data.age }}</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

Suggested change
<span v-if="data.age || data.age === 0" class="text-gray-500">{{ data.age }}</span>
<span v-if="data.age >= 0" class="text-gray-500">{{ data.age }}</span>

?

@djaiss djaiss changed the title fix: "Unknown Age" for babies fix: unknown age for babies Oct 27, 2024
@djaiss djaiss merged commit 4e90bd6 into monicahq:main Oct 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants