Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete "me" contact when deleting the contact #6531

Closed
wants to merge 8 commits into from

Conversation

ccrims0n
Copy link

@ccrims0n ccrims0n commented Jan 23, 2023

First of all thanks so much for taking the time to open a pull request and help the project. It's because of people like you that we love working on this project.

Please read the list below. Feel free to delete this text after but we need you to read it so we make sure that the project is consistent and remains of quality.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • If you change the UI, make sure to ask repositories administrators first about your changes by pinging djaiss or asbiin in this PR.
  • Screenshots are included if the PR changes the UI.
  • Front-end tests have been written with Cypress.

Backend/models changes

  • The API has been updated.
  • API's documentation has been added by submitting a pull request in the marketing website repository.
  • Tests have been added for the new code.
  • If you change a model, make sure the SetupTest file is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • Make sure exporting account data as SQL is still working.
  • Make sure your changes do not break importing data with vCard and .csv files.
  • Make sure account reset and deletion still work.

Other tasks

  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

* Add deleted observer on the contact model
@CLAassistant
Copy link

CLAassistant commented Jan 23, 2023

CLA assistant check
All committers have signed the CLA.

@ccrims0n ccrims0n marked this pull request as ready for review March 1, 2023 02:54
app/Models/Contact/Contact.php Outdated Show resolved Hide resolved
tests/Feature/MeTest.php Outdated Show resolved Hide resolved
@asbiin asbiin changed the title Fix #5981 fix: delete "me" contact when deleting the contact Oct 31, 2023
@asbiin
Copy link
Member

asbiin commented Mar 16, 2024

This needs more work, and we don't accept more changes in the 4.x branch. Don't hesitate to reopen it on the main branch if that makes sense.

@asbiin asbiin closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants