DOP-4227: Chatbot FAB on all Docs pages #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeigs
changed the title
seungpark
reviewed
Jan 12, 2024
There was a problem hiding this comment.
minor comments below!
was a bit confused why we are using different chatbot in existing chatbot but realized that was a specific docs chatbot they had rolled out previously 😄
also would note that the z-index of the modal is at 100, while the z-index of the header is at 1000... so they are not playing friendly together
|
The Chatbot modal now appears over the consistent-nav as can be seen in this build. Also, moving the |
mmeigs
commented
Jan 16, 2024
| return ( | ||
| <StyledChatBotFabContainer | ||
| // Inline style to default hide Chatbot FAB, Optimizely to flip this on client-side | ||
| // style={{ display: 'none' }} // TODO: uncomment line before merge |
There was a problem hiding this comment.
Reminder to myself: uncomment before merge
seungpark
reviewed
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4227
DOP-4219
Staging Links:
Staging Links with Chatbot "enabled"
Homepage (to show it's not there)
Legacy page (to show both FABs)
Staging Link with Chatbot "disabled" (ie display: none)
Legacy page
Notes:
This PR adds the Chatbot Floating Action Button to all Docs pages except for the Docs main landing page.
Background: this will be default inline-style
display:none. The optimizely script and team will have a way for A/B testing to toggle this style on and off for certain groups of users.Figma
Currently the Chatbot sends a CORS error, but this is almost certainly only an error in staging. Will be testing this in preprd once we merge and have bandwidth.