DOP-4065 frontend #937
Merged
DOP-4065 frontend #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayangler
reviewed
Oct 30, 2023
Comment on lines
171
to
172
| {facets.filter(getFacetName).map((facet) => ( | ||
| <StyledTag variant={getFacetTagVariant(facet)}>{getFacetName(facet)}</StyledTag> |
There was a problem hiding this comment.
(No change needed; more for discussion) I noticed that in the designs, the parent target product is typically the leftmost facet tag in the search result, but this might not be true with the current implementation. Is this something that we should have docs-search-transport handle?
There was a problem hiding this comment.
i agree with the suggestion. the front end should not be responsible for sorting (re discussion of taxonomy order in https://jira.mongodb.org/browse/DOP-4109)
rayangler
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4065
Description:
This PR utilizes new attributes returned from /search API endpoint, specifically
documents[].facets[]Example here: https://docs-search-transport.mongodb.com/search?q=$andGoal is the show the tagged facets on each document in the search results
Current Behavior:
Current behavior on prod:
Current behavior on master with feature flag on, shows no facet tags on search results
Staging Links:
Staged changes with feature flag = off
Staged changes with feature flag on