DOP-5093: make tabs selectors interactive on offline builds #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-frontend-dotcomprd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-frontend-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
seungpark
commented
Dec 12, 2024
| @@ -4,7 +4,8 @@ const { siteMetadata } = require('../site-metadata'); | |||
|
|
|||
| const GATSBY_IMAGE_EXTENSIONS = ['webp', 'png', 'avif']; | |||
|
|
|||
| const needsImageOptimization = ['dotcomprd', 'dotcomstg'].includes(siteMetadata.snootyEnv); | |||
| const needsImageOptimization = | |||
There was a problem hiding this comment.
minor change to prevent image optimization from offline builds. will put in a separate PR if preferred!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-5093
Staging Links:
Link to download sample HTML
Another page on cloud docs with tabs selectors
The full bundle can be located in this S3 path . Each html file could be downloaded and inspected to see that tabs selectors are working
Regression check to verify tabs selectors have no regression without the
OFFLINE_DOCSflagNotes:
This PR makes tab selectors work in offline docs, by making a custom menu dropdown (similar to the Select menu dropdown) and a script to enable the UI/UX
README updates