Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 DOP-4363 fixes bug for submitting a feedback with a screenshot #1043

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

caesarbell
Copy link
Collaborator

@caesarbell caesarbell commented Mar 19, 2024

Stories/Links:

DOP-4363

Current Behavior:

https://www.mongodb.com/docs/manual/

Staging Links:

staging commit

Notes:

This PR, fixes the "Submit Feedback with Screenshot" bug, by dynamically setting the z-index on the widget container. It also provides a utility for dynamically setting and resetting a z-index based on the selector given.

Screenshots

Screenshot 2024-03-19 at 1 01 40 PM

Screenshot 2024-03-19 at 12 39 43 PM

Screenshot 2024-03-19 at 12 39 27 PM

Stored Screenshot

https://docs-feedback-screenshots.s3.us-east-2.amazonaws.com/screenshot-65f9c1141ea69e0248784367.png

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 non-blocking comments/questions, but this lgtm as-is

@caesarbell caesarbell merged commit b623b6f into main Mar 20, 2024
4 checks passed
@caesarbell caesarbell deleted the DOP-4363 branch March 20, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants