PYTHON-3096 Finish implementation and tests for GSSAPI options #1985
Conversation
| af, socktype, proto, canonname, sockaddr = socket.getaddrinfo( | ||
| hostname, None, 0, 0, socket.IPPROTO_TCP, socket.AI_CANONNAME | ||
| )[0] | ||
|
|
||
| # For forward just to resolve the cname as dns.lookup() will not return it. | ||
| if option == "forward": |
There was a problem hiding this comment.
It looks like the string "none" is also valid:
def _validate_canonicalize_host_name(value: str | bool) -> str | bool:
valid_names = [False, True, "none", "forward", "forwardAndReverse"]
Should that have the same behavior as False? Or should validate convert "none" to False?
There was a problem hiding this comment.
I changed it to convert "none" to false, so the three validated options are True, False, and "forward".
There was a problem hiding this comment.
Actually no, the spec test is expecting it to validate as a string, so I updated the business logic instead.
| await client.server_info() | ||
|
|
||
| if props["CANONICALIZE_HOST_NAME"] == "none": | ||
| return |
There was a problem hiding this comment.
This if-statement should be removed since it's redundant, or is there something missing?
| af, socktype, proto, canonname, sockaddr = socket.getaddrinfo( | ||
| hostname, None, 0, 0, socket.IPPROTO_TCP, socket.AI_CANONNAME | ||
| )[0] | ||
|
|
||
| # For forward just to resolve the cname as dns.lookup() will not return it. | ||
| if option == "forward": | ||
| return canonname.lower() |
There was a problem hiding this comment.
I'm still confused by this method. DRIVERS-1803 says:
"forward" is equivalent to the current behaviour of true (a forward DNS lookup)
But here we are introducing new behavior for "forward". Is that because our behavior for "true" is actually "forwardAndReverse"? If so could you add a comment mentioning that?
There was a problem hiding this comment.
Ah, I misinterpreted the Node implementation and got confused. I'll redo the logic.
No description provided.